fix initial run of release-check workflow #213
Conversation
| - name: Install semver (node command line tool) | ||
| if: env.INITIAL_RUN == 'false' |
There was a problem hiding this comment.
It's really annoying that there's no way to exit early from a GH Actions workflow (without failing the workflow run).
There was a problem hiding this comment.
I wonder if you could split this workflow into two jobs; have the second job depend on the first one, and only run if INITIAL_RUN==true.
There was a problem hiding this comment.
To some degree, we could consider the same for COMPARE_TO.
There was a problem hiding this comment.
Hmm, I think in a previous PR I had suggested to use underscores to make env var names like COMPARETO easier to read. Maybe that slipped through the cracks :)
There was a problem hiding this comment.
I wonder if you could split this workflow into two jobs; have the second job depend on the first one, and only run if INITIAL_RUN==true.
That comes at the expense of booting up two runners, checking out the repo twice and passing around env.VERSION. I still hope that GitHub gives us a way to cleanly do an early exit from workflows :)
Hmm, I think in a previous PR I had suggested to use underscores to make env var names like COMPARETO easier to read. Maybe that slipped through the cracks :)
I remember making that change, but it must have gotten swallowed by git at some point. Sorry.
marten-seemann
force-pushed
the
fix-initial-release-check
branch
3 times, most recently
from
67207ed
to
9a68a6c
Compare
marten-seemann
force-pushed
the
fix-initial-release-check
branch
from
9a68a6c
to
d68bc00
Compare
|
The logic in the original PR was wrong. In order to determine if this is the initial run of a workflow, we can't only look if I fixed the logic by checking that in addition to |
| - name: Install semver (node command line tool) | ||
| if: env.INITIAL_RUN == 'false' |
There was a problem hiding this comment.
I wonder if you could split this workflow into two jobs; have the second job depend on the first one, and only run if INITIAL_RUN==true.
| - name: Install semver (node command line tool) | ||
| if: env.INITIAL_RUN == 'false' |
There was a problem hiding this comment.
To some degree, we could consider the same for COMPARE_TO.
| - name: Install semver (node command line tool) | ||
| if: env.INITIAL_RUN == 'false' |
There was a problem hiding this comment.
Hmm, I think in a previous PR I had suggested to use underscores to make env var names like COMPARETO easier to read. Maybe that slipped through the cracks :)
When we first deploy this workflow, we're adding the
version.jsonfile. For this PR, we don't want to run therelease-checkworkflow, as a release for this version number already exists.Tested on the
testingbranch. Since this is a called workflow, we don't have run a new deployment to roll out this fix :)